fix: avoid duplicate report rows for pytest 9 subtests - #1076
Open
xuanshen666 wants to merge 1 commit into
Open
xuanshen666 wants to merge 1 commit into
xuanshen666 wants to merge 1 commit into
Conversation
Author
|
Note: the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a test uses the new
subtestsfixture from pytest 9 and has mixed pass/fail subtest outcomes, pytest-html generates two rows for the same test (one "Passed" and one "Failed").Why
Each subtest emits its own
pytest_runtest_logreportwithwhen="call"and the samenodeid. pytest-html stores these per-subtest reports as separate result rows instead of collapsing them into the parent test's single row.How
In
BaseReport.pytest_runtest_logreport, skip subtest reports (identified by thecontextattribute). The parent test's owncallreport already contains the full subtest details, so a single row is still produced with the correct outcome and log.Verification
test_subtests_single_rowtotesting/test_unit.py(skipped on pytest < 9).Passed,Failed); after the fix it produces 1 row (Failed).pytest testing/test_unit.pypasses (8 passed).Closes #981