add test coverage for weird case of plugin with multiple impls of same spec#446
Open
wahuneke wants to merge 2 commits intopytest-dev:mainfrom
Open
add test coverage for weird case of plugin with multiple impls of same spec#446wahuneke wants to merge 2 commits intopytest-dev:mainfrom
wahuneke wants to merge 2 commits intopytest-dev:mainfrom
Conversation
wahuneke
force-pushed
the
multi-impl-testing
branch
from
dc9fb8e to
52d8e31
Compare
RonnyPfannschmidt
approved these changes
Sep 22, 2023
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
well done, those tests verify that my assessment from just/only looking at the code was wrong and now we have a demonstration of the correctness for those cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are attempting to find @RonnyPfannschmidt 's theoretical issue described in issue #431 . Conversation in 431 is ongoing. This PR is here for reference. It is a DRAFT.
NOTE: these tests currently pass. They do not detect any new issues.