-
Notifications
You must be signed in to change notification settings - Fork 16
Comprehensive user guide rewrites/updates #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…omewhere the docs can find it.
…can be generated.
…h submodule. All to be autogenerated from the source files in ./pyscript.
2bc3162 to
d6bf860
Compare
|
OK. I've done the final corrections and checks. Ready for review. NOTE The examples do not work as is because version 2026.1.1 has not (yet) been released. When this happens, it'll all work. 👍 |
WebReflection
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to be honest: there is no way I can properly review all of this until it's published, transformed and whatnot but as I trust you tested everything locally, and because this will not break, strictly speaking, our users' code or projects, as it's about documentation and not library logic, I think the best way forward is to approve and refine anything we think should be refined as a separate (one or more) PRs.
The alternative is to split this MR into dozen different MRs, one per each example + one per docs changes (or each page) but I don't think it's worth it ... what do you think? I let this be your call, hopefully this approach is reasonable to you.
|
@WebReflection yeah - this is a difficult one. It's an all-or-nothing type change that relates to a specific version of PyScript. I agree though - to the best of my ability I've checked (and double checked). Obviously, we're all human and mistakes will get through but we can fix them and refine as/when we notice them. Next steps:
Sound like a plan? |
|
works for me ... specially the part we update all the things on each released version, which is the most important bit. out of curiosity: why some example needs/uses 2026.1.1, if I might ask? |
|
@WebReflection it's the new |
SOME OF THE EXAMPLES WON'T WORK because they target 2026.1.1 (which is yet to be released).
This PR is stacked on the work done to automatically generate API docs from our source code. It must only be merged after the next release of PyScript, since it documents and makes use of some of the breaking (
pyscript.webrelated) changes.This PR involves:
TODO:
FEEDBACK WELCOME