Skip to content

Fix Read Fifo Query RTU Frame Size #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 3 commits into from
Feb 26, 2026
+2 −2
Merged

Fix Read Fifo Query RTU Frame Size #2898

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd3d7e0
Fix ReadFifoQueueResponse RTU Frame Size
brambo123 Feb 25, 2026
69417a7
Fix ReadFifoQueueResponse RTU Frame Size
brambo123 Feb 25, 2026
e1eab92
Try to fix test_frame_size for ReadFifoQueue
brambo123 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymodbus/pdu/file_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def calculateRtuFrameSize(cls, data: bytes) -> int:
"""Calculate the size of the message."""
hi_byte = int(data[2])
lo_byte = int(data[3])
return ((hi_byte << 16) + lo_byte) * 2 + 6
return ((hi_byte << 16) + lo_byte) + 4

def __init__(self, values: list[int] | None = None, dev_id: int = 1, transaction_id:int = 0) -> None:
"""Initialize a new instance."""
Expand Down