fix incorrect comment in StructuredDot.grad#1890
Conversation
|
I don't have the context of why that |
@ricardoV94 the new comments reflect the state of things, but I think the real question is whether we want different backends to support different input types. |
The alternative is for all the backends to support everything? That's WIP but why must such note live in this method? Is the implementation trying to change things because of this? It won't know which backend will be ultimately used... |
I think so, although I don't know if there's appetite to update the C code.
The origin of this is there was a note, in the exact same place, saying
Nope, but the original comment was wrong and I've noticed so they are the parameter names in |
Description
This PR resolves #1871 by correcting outdated and misleading comments in the
StructuredDot.gradmethod.Changes:
ga. It previously described a standard dense dot product (structured_dot_gradto maintain the sparsity pattern ofa.bandg_outmust be dense.StructuredDotGradCSRandStructuredDotGradCSCin numba backend #1860) but are not yet supported by the C backend.Related Issue
StructuredDot.gradis not correct #1871Checklist
Type of change