Skip to content

Add transPath to input#77

Open
samwaseda wants to merge 1 commit intomainfrom
transpath
Open

Add transPath to input#77
samwaseda wants to merge 1 commit intomainfrom
transpath

Conversation

@samwaseda
Copy link
Copy Markdown
Member

This pull request adds support for the transPath group to the ricTS section in the Sphinx input parser. The transPath group allows users to specify an initial guess for the atomic displacement pattern along the transition direction, which is important for transition state searches. The changes include updates to both the Python parser logic and the YAML schema.

New feature: transPath support in ricTS:

  • Added an optional transPath parameter to the _sphinx__main__ricTS function, updated its docstring, and ensured it is passed to the underlying value filler. (sphinx_parser/input.py) [1] [2] [3]
  • Implemented the _sphinx__main__ricTS__transPath helper function to handle the transPath group, including its arguments (dir_, atomId, atomIds) and documentation. (sphinx_parser/input.py)

Schema update:

  • Added the transPath group to the sphinx.main.ricTS section in the YAML schema, with fields for atomId, atomIds, and dir, along with descriptions and data types. (sphinx_parser/src/input_data.yml)

@samwaseda samwaseda requested a review from freyso May 6, 2026 11:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Binder 👈 Launch a binder notebook on branch pyiron/sphinx_parser/transpath

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 5 duplication

Metric Results
Complexity 0
Duplication 5

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (ef195f2) to head (9c85454).

Files with missing lines Patch % Lines
sphinx_parser/input.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   88.70%   88.63%   -0.07%     
==========================================
  Files           8        8              
  Lines         841      845       +4     
==========================================
+ Hits          746      749       +3     
- Misses         95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant