Skip to content

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jan 15, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • Extended HDF5 serialization to support resource dictionaries. Resource data is now automatically saved and loaded when working with HDF5 files, improving data completeness and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@jan-janssen jan-janssen marked this pull request as draft January 15, 2026 15:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

The PR adds support for serializing and deserializing a new resource_dict data item in HDF5 format. The mapping configuration is updated, and dump/load operations now handle the field's presence and default to an empty dictionary when absent.

Changes

Cohort / File(s) Summary
HDF5 Resource Dictionary Support
src/executorlib/standalone/hdf.py
Added "resource_dict" entry to group_dict mapping for HDF5 serialization; updated dump logic to create datasets for resource_dict when present; updated load logic to retrieve resource_dict from /resource_dict or default to empty dict

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A dict for resources, now saved with care,
In HDF5 format, stored here and there,
When dumping, we write it, when loading, retrieve,
Seven lines of magic, just watch and believe! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Store resource dict in cache' accurately describes the main change in the pull request, which adds support for storing resource_dict in HDF5 serialization.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3176bb4 and 5c75ae0.

📒 Files selected for processing (1)
  • src/executorlib/standalone/hdf.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
  • GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
🔇 Additional comments (2)
src/executorlib/standalone/hdf.py (2)

14-14: LGTM!

The mapping addition follows the existing pattern and enables resource_dict to be serialized by the dump function and loaded by _get_content_of_file.


65-70: LGTM!

The load logic for resource_dict correctly follows the established pattern used for other optional fields like input_args and input_kwargs — checking for existence and providing an appropriate default (empty dict). This ensures backward compatibility with existing HDF5 files that don't contain this field.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (beb21cb) to head (5c75ae0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   93.41%   93.42%   +0.01%     
==========================================
  Files          38       38              
  Lines        1837     1840       +3     
==========================================
+ Hits         1716     1719       +3     
  Misses        121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen marked this pull request as ready for review January 15, 2026 17:34
@jan-janssen jan-janssen merged commit 575a482 into main Jan 15, 2026
61 of 63 checks passed
@jan-janssen jan-janssen deleted the resource_dict branch January 15, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants