Fix tab switch when projected is mutually applied#2742
Open
Skybladev2 wants to merge 5 commits intopyfa-org:masterfrom
Open
Fix tab switch when projected is mutually applied#2742Skybladev2 wants to merge 5 commits intopyfa-org:masterfrom
Skybladev2 wants to merge 5 commits intopyfa-org:masterfrom
Conversation
Complements the PROJECTED calc marking fix: the graph must run a full local recalc for each listed fit, not only the active tab, so incoming projected effects are reflected in speeds and damage for every ship in the comparison. Made-with: Cursor
Drop graph frame recalculation changes from this branch so it only contains fit calculation fixes and can be composed with focus-graph cleanly. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When 2 fits are mutually applied in Projected tabs to each other, the first fit loses the projected effect.
For example, we have fit1:
and fit2:
Each one has a Stasis Webifier.
When the first fit applies projected effect from the second one everything is fine:
When the second fit applies projected effect from the first one everything is fine:
When we switch back to the first fit tab, the projected effect is lost:
It can be restored by re-enabling the projected effect, but then the effect is lost on the second fit tab:
If we re-enable it here, the first fit loses the projected effect and so on.
Solution
Don't skip recalculation of modified attributes for projected calculation type (similar to command, see #1193).