Conversation
|
Ugh 🤦 I should test the stuff I cherry-pick from another branch... brb |
Signed-off-by: Alex Snaps <[email protected]>
PiotrSikora
left a comment
There was a problem hiding this comment.
Any chance that you could add a simple gRPC example to Proxy-Wasm Rust SDK that would exercise the new code paths?
Yes, we want to test the test framework :)
|
Yeah. I'll try to find something that avoids pulling things other than basic types tho, to avoid needing protoc - wdyt? |
|
Definitely! The simpler the better. |
|
FYI, I've added basic gRPC example in proxy-wasm/proxy-wasm-rust-sdk#248. |
Merged in #23. Could you add coverage for them in this PR? Thanks! |
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
gRPC call example
|
@PiotrSikora thanks to @eguzki I think this has it all now, or do we miss anything? |
|
I would also add Kuadrant#6, as it supports assert on GRPC call errors and breaks backward compat regarding the API introduced in this PR. |
This is one of the two additions we've done to the framework: support asserting on gRPC calls
Follow up would be reading properties: Kuadrant#1