Explicitly include header for std::string to appease clang-tidy.#513
Merged
leonm1 merged 1 commit intoproxy-wasm:mainfrom Mar 9, 2026
Merged
Explicitly include header for std::string to appease clang-tidy.#513leonm1 merged 1 commit intoproxy-wasm:mainfrom
leonm1 merged 1 commit intoproxy-wasm:mainfrom
Conversation
kenbarr1
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
mpwarres
approved these changes
Mar 9, 2026
Contributor
|
This is failing the DCO check. You need to amend your commit message to include the following line: After doing that, you'll need to force-push to update this PR. (Simply stacking an additional commit won't work, since the commit without DCO will still be part of the PR, unless you amend the existing commit and force-push.) |
Signed-off-by: Ken Barr <kenbarr@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly include header for std::string to appease clang-tidy.