Open
Conversation
nateinaction
reviewed
Aug 6, 2025
Member
nateinaction
left a comment
nateinaction
left a comment
There was a problem hiding this comment.
I think this looks good, suggested moving some code to pysquared.
Member
There was a problem hiding this comment.
Let's bring this into the pysquared repo. How about we create a new module inside of pysquared called boot and we can add this as a callable function from that module. It looks like the function might take 3 arguments: mount_points, wait_time, and attempts. Once it's in pysquared, we can write tests and reuse this in the other board repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created sdCardManager class to initialize and mount sd card. The logger takes in the sd card to ensure that it is mounted and writes all logs into the sd card at /sd/logs/activity.log.
Added logic to write to the sd card inside of the _log function of the Logger.
How was this tested