fix some fc-hba are missing the statistics/*#664
Open
chijiajian wants to merge 8 commits intoprometheus:masterfrom
Open
fix some fc-hba are missing the statistics/*#664chijiajian wants to merge 8 commits intoprometheus:masterfrom
chijiajian wants to merge 8 commits intoprometheus:masterfrom
Conversation
Signed-off-by: jiajian.chi <jiajian.chi@zstack.io>
On branch fixFibrechannel Changes to be committed: modified: sysfs/class_fibrechannel.go Signed-off-by: jiajian.chi <jiajian.chi@zstack.io>
chijiajian
force-pushed
the
fixFibrechannel
branch
from
f187d47 to
e4deace
Compare
SuperQ
requested changes
Sep 23, 2024
delete Printf Signed-off-by: chijiajian <33536362+chijiajian@users.noreply.github.com>
discordianfish
approved these changes
Oct 24, 2024
Refactor error handling for statistics directory check. Signed-off-by: chijiajian <33536362+chijiajian@users.noreply.github.com>
chijiajian
commented
Feb 28, 2026
Author
chijiajian
left a comment
chijiajian
left a comment
There was a problem hiding this comment.
Fixed — now explicitly checking for fs.ErrNotExist and returning other errors.
Signed-off-by: chijiajian <33536362+chijiajian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some FC-HBA cards are missing the /sys/class/fc_host//statistics/* directory and files, for example, the Huawei Technologies Co., Ltd. Hi1822 Family (2*16G FC) (rev 45) card with ID 3e:00.0. However, there are corresponding port_name, port_state, etc., under /sys/class/fc_host//. It is recommended to add a check in the parseFibreChannelStatistics function in the class_fibrechannel.