collector/systemd: add system_state_info metric and use timed contexts#3648
Open
arch-yunus wants to merge 1 commit intoprometheus:masterfrom
Open
collector/systemd: add system_state_info metric and use timed contexts#3648arch-yunus wants to merge 1 commit intoprometheus:masterfrom
arch-yunus wants to merge 1 commit intoprometheus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the systemd collector by adding a new info metric for the overall system state and improving the reliability of DBus communications.
Changes
Added node_systemd_system_state_info metric: Exposes the system state (e.g., running, degraded) as a label.
Implemented Timed Contexts for DBus: Replaced context.TODO() with a context that has a configurable timeout (default 5s).
New Flag --collector.systemd.dbus-timeout: Allows configuration of the DBus call timeout.
Testing
Verified with local systemd collector tests.
Confirmed build stability with go build.