diskstats_linux.go: add collector.diskstats.disable-queue-stats flag#3283
Open
wjordan wants to merge 1 commit intoprometheus:masterfrom
Open
diskstats_linux.go: add collector.diskstats.disable-queue-stats flag#3283wjordan wants to merge 1 commit intoprometheus:masterfrom
wjordan wants to merge 1 commit intoprometheus:masterfrom
Conversation
Skips call to `SysBlockDeviceQueueStats` to improve performance over a large number of devices.
SuperQ
reviewed
Mar 27, 2025
| ) | ||
|
|
||
| var ( | ||
| disableQueueStats = kingpin.Flag("collector.diskstats.disable-queue-stats", "disable queue stats").Default("false").Bool() |
Member
There was a problem hiding this comment.
We usually prefer "positive" flags. Then the disable would be --no-collector.diskstats.enable-queue-stats
This makes the explicit version of the disable less awkward looking (--no-collector.diskstats.disable-queue-stats).
Suggested change
| disableQueueStats = kingpin.Flag("collector.diskstats.disable-queue-stats", "disable queue stats").Default("false").Bool() | |
| enableQueueStats = kingpin.Flag("collector.diskstats.enable-queue-stats", "enable queue stats").Default("true").Bool() |
SuperQ
requested changes
Mar 27, 2025
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
If we can flip the boolean meaning, I'd be happy to get this into 1.9.1.
Member
|
This needs a DCO sign-off. You can use |
Merged
Member
|
Ping, are you able to finish this work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flag to skip the call to
SysBlockDeviceQueueStatsin thediskstatscollector, to improve performance over a large number of devices when the extrarotationallabel is not needed on theinfometric.Fixes #3282.
I don't have a strong preference on the naming or default, as long as it can be configured. In the PR, I named it
collector.diskstats.disable-queue-statsdefaulting tofalse, since this is probably an uncommon issue affecting systems with many (thousands) of block devices.