Skip to content

OM2: Metric/MetricFamily.Name escaping consistency #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 2 commits into from
Mar 30, 2026
+11 −0
Merged

OM2: Metric/MetricFamily.Name escaping consistency #2938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a694e
OM2: Metric/MetricFamily.Name escaping consistency
bwplotka Mar 30, 2026
add2d5e
Apply suggestions from code review
bwplotka Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/specs/om/open_metrics_spec_2_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,17 @@ There MUST NOT be an explicit separator between MetricFamilies. The next MetricF

MetricFamilies MUST NOT be interleaved.

The same MetricFamily's Name and Metric's Name SHOULD have the same quoting.

An example that would violate this:

```openmetrics-add-eof
# TYPE "read_errors" counter
# HELP read_errors The number of errors in the read path for fooDb.
{"read_errors","service.name"="my_service"} 3482
read_errors{"service.name"="my_service2"} 123
```

#### MetricFamily metadata

There are four pieces of metadata: The MetricFamily name, TYPE, UNIT and HELP. An example of the metadata for a counter Metric called `foo_total` is:
Expand Down
Loading