Conversation
ywwg
force-pushed
the
owilliams/om2-migration
branch
from
8edfbbb to
9aaafa1
Compare
ywwg
commented
Mar 19, 2026
bwplotka
reviewed
Mar 20, 2026
bwplotka
reviewed
Mar 20, 2026
bwplotka
reviewed
Mar 20, 2026
bwplotka
reviewed
Mar 20, 2026
bwplotka
reviewed
Mar 20, 2026
bwplotka
reviewed
Mar 20, 2026
ywwg
changed the title
Member
Author
|
Addressed comments, including the new definition of "breaking" (which is, something that used to be valid in om 1.0 that is invalid in om 2.0) |
dashpole
previously approved these changes
Mar 24, 2026
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
Just some non-blocking editorial comments
dashpole
reviewed
Mar 25, 2026
dashpole
reviewed
Mar 25, 2026
Member
Author
|
hilariously, almost all of your comments were for text I added after the LLM did its thing :). applied the notes and made a couple other tweaks |
krajorama
reviewed
Mar 26, 2026
dashpole
reviewed
Mar 28, 2026
dashpole
previously approved these changes
Mar 28, 2026
ywwg
force-pushed
the
owilliams/om2-migration
branch
from
556c821 to
9b8c18e
Compare
Member
Author
|
squashed down |
bwplotka
reviewed
Mar 30, 2026
krajorama
reviewed
Mar 30, 2026
ywwg
force-pushed
the
owilliams/om2-migration
branch
from
00cef43 to
f5743f7
Compare
dashpole
previously approved these changes
Mar 30, 2026
bwplotka
requested changes
Apr 1, 2026
Member
There was a problem hiding this comment.
Just started detailed pass.
I propose we improve it a bit before merging. It needs more human touch IMO, for better accessibility, consistency. There are some AI odd pieces here. 🤔
It just doesn't pass my (personal) quality bar
Happy to help, propose changes this week!
bwplotka
previously approved these changes
Apr 1, 2026
bwplotka
reviewed
Apr 1, 2026
|
|
||
| This guide covers the changes from OpenMetrics (OM) 1.0 to OpenMetrics 2.0 that affect client library (i.e. exposers) implementations. Sections are organized so you can implement changes incrementally, starting with version negotiation and working through metric types, syntax, and metadata. This guide may contain errors, and in any case where this document disagrees with the spec document, **the spec document is the authoritative source of truth**. | ||
|
|
||
| > WARNING: OpenMetrics 2.0 is currently experimental (release candidate versions), so some details might change. Track progress at the [OpenMetrics 2.0 work group issue](https://github.com/prometheus/OpenMetrics/issues/276). |
Member
There was a problem hiding this comment.
Suggested change
| > WARNING: OpenMetrics 2.0 is currently experimental (release candidate versions), so some details might change. Track progress at the [OpenMetrics 2.0 work group issue](https://github.com/prometheus/OpenMetrics/issues/276). | |
| > NOTE: OpenMetrics 2.0 is currently experimental (release candidate versions), so some details might change. Track progress at the [OpenMetrics 2.0 work group issue](https://github.com/prometheus/OpenMetrics/issues/276). |
Migration guide for SDK authors on how to update SDKs for OM2.0 Signed-off-by: Owen Williams <owen.williams@grafana.com>
ywwg
force-pushed
the
owilliams/om2-migration
branch
from
44c2fb0 to
138a70a
Compare
Signed-off-by: Owen Williams <owen.williams@grafana.com>
bwplotka
reviewed
Apr 1, 2026
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…illiams/om2-migration
bwplotka
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration guide for SDK authors on how to update SDKs for OM2.0
claude did the initial drafting and then I went over it carefully and refined / corrected based on my own understanding.