[deps] upgrade to cenkalti/backoff/v5#5378
Conversation
Signed-off-by: Guido Trotter <guido@hudson-trading.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR upgrades the github.com/cenkalti/backoff dependency from v4 to v5 in go.mod, and updates notify/retry_stage.go to import backoff/v5, removing the explicit MaxElapsedTime override and relying on context cancellation to stop retries. ChangesBackoff Dependency Upgrade
Estimated code review effort: 2 (Simple) | ~10 minutes Related PRs: None identified from the provided context. Suggested labels: dependencies, go Suggested reviewers: None identified from the provided context. 🐰 A backoff hopped from four to five, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The newest version is /v7, but we already have v5 in the codebase via OTel, so upgrading to v5 allows us to depend into just one copy of this library.
Pull Request Checklist
Please check all the applicable boxes.
Which user-facing changes does this PR introduce?