Skip to content

[deps] upgrade to cenkalti/backoff/v5#5378

Merged
siavashs merged 1 commit into
prometheus:mainfrom
ultrotter:backoffv5
Jul 12, 2026
Merged

[deps] upgrade to cenkalti/backoff/v5#5378
siavashs merged 1 commit into
prometheus:mainfrom
ultrotter:backoffv5

Conversation

@ultrotter

Copy link
Copy Markdown
Contributor

The newest version is /v7, but we already have v5 in the codebase via OTel, so upgrading to v5 allows us to depend into just one copy of this library.

Pull Request Checklist

Please check all the applicable boxes.

Which user-facing changes does this PR introduce?

NONE

Signed-off-by: Guido Trotter <guido@hudson-trading.com>
@ultrotter ultrotter requested a review from a team as a code owner July 7, 2026 12:36
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f933a68b-e549-49f2-a30c-185ee4b8cb98

📥 Commits

Reviewing files that changed from the base of the PR and between 963ed72 and 8c2bee9.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod
  • notify/retry_stage.go

📝 Walkthrough

Walkthrough

This PR upgrades the github.com/cenkalti/backoff dependency from v4 to v5 in go.mod, and updates notify/retry_stage.go to import backoff/v5, removing the explicit MaxElapsedTime override and relying on context cancellation to stop retries.

Changes

Backoff Dependency Upgrade

Layer / File(s) Summary
Dependency version bump
go.mod
Direct requirement changed from backoff/v4 v4.3.0 to backoff/v5 v5.0.3; removed the redundant indirect backoff/v5 entry.
Retry stage backoff usage update
notify/retry_stage.go
Import switched to backoff/v5; removed MaxElapsedTime = 0 override and added a comment explaining that v5's exponential backoff never signals Stop, so retries continue until context cancellation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related PRs: None identified from the provided context.

Suggested labels: dependencies, go

Suggested reviewers: None identified from the provided context.

🐰 A backoff hopped from four to five,
No more a fixed time to survive,
The context now holds the reins,
Retries persist through all the lanes,
A tiny bump keeps alerts alive.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the dependency upgrade to cenkalti/backoff/v5.
Description check ✅ Passed The description is related to the dependency upgrade and explains the motivation for switching to v5.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@siavashs siavashs merged commit 2512db5 into prometheus:main Jul 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants