Added SDL_HINT_APP_NAME#124
Conversation
kblaschke
left a comment
There was a problem hiding this comment.
Please amend your commit to remove the comment regarding the ::name() return value, then I can merge the PR.
| const char* SDLRenderingWindow::name() const | ||
| { | ||
| return "SDL2 Rendering Window"; | ||
| return "SDL2 Rendering Window"; // Why..? This isn't used anywhere |
There was a problem hiding this comment.
Because this method must be implemented, please read the docs:
https://docs.pocoproject.org/current/Poco.Util.Subsystem.html#36011
Please remove this comment, then I can merge the PR.
… correctly identifying the name of the application.
…orrectly recognizing the application name
|
Sorry, I have no idea how to properly work with git (outside school projects), much less github and pull requests. |
You'd also have to remove the merge commit you've added. Sadly, I can't edit your branch as you've used your So we've got a few options here:
|
No description provided.