Improve InviteScreen UI with join icon and loading state#708
Improve InviteScreen UI with join icon and loading state#708kevinaboos wants to merge 3 commits intomainfrom
Conversation
- Replaced default checkmark icon with `ICON_JOIN_ROOM` for the join button. - Added a `loading_view` that mimics the button style but displays a `LoadingSpinner` and "Joining..." text. - Implemented state logic to toggle between the join button and the loading view during the join process. - Upon successful join, the button shows "Joined!" with a checkmark icon. Closes #592 (partially, ignores room closing logic). Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add `joined_view` to `InviteScreen` to show "Joined!" success state. - Update `accept_button` to use `ICON_JOIN_ROOM` for initial state. - Implement state logic in `draw_walk` to toggle visibility between `accept_button`, `loading_view`, and `joined_view`. - Fixed CI error by avoiding `apply_over` with undefined Rust constants. Closes #592 (partially, ignoring room close logic). Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
- Add `joined_view` to `InviteScreen` to show "Joined!" success state. - Update `accept_button` to use `ICON_JOIN_ROOM` for initial state. - Implement state logic in `draw_walk` to toggle visibility between `accept_button`, `loading_view`, and `joined_view`. - Fixed CI error by avoiding `apply_over` with undefined Rust constants. Closes #592 (partially, ignoring room close logic). Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
1 participant
This PR improves the visual feedback on the
InviteScreen. It changes the initial join button icon to an "enter room" icon. When the user clicks join, the button is replaced by a loading view with a spinner and "Joining..." text. Upon success, the button reappears disabled with "Joined!" text and a checkmark icon. This addresses the UI improvements requested in issue #592.PR created automatically by Jules for task 6843606584321878320 started by @kevinaboos