Simplify ticket emails and add Apple/Google Wallet passes#165
Open
Simplify ticket emails and add Apple/Google Wallet passes#165
Conversation
…icket card HTML The file contained much more than QR utilities. Switched from base64 data URLs (blocked by many email clients) to CID-attached PNGs for reliable QR rendering. Removed buildTicketCardHtml/buildTicketListHtml in favor of CMS-managed templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Generates .pkpass (Apple) and signed JWT URL (Google) when an attendee completes their profile. Apple pass is attached to the email and served via a new /ticket-wallet/apple endpoint. Google Wallet is a link. Both degrade gracefully when credentials are not configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix asset path resolution to work from both source and dist. Add wallet background images and icon/logo assets. Include inline Google Wallet class creation. Use getSetting helper in wallet endpoint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a055f83a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...s/extensions/directus-extension-programmierbar-bundle/src/ticket-profile-completion/index.ts
Show resolved
Hide resolved
...s/extensions/directus-extension-programmierbar-bundle/src/ticket-profile-completion/index.ts
Outdated
Show resolved
Hide resolved
The hardcoded /api/directus/ prefix assumed a proxy that doesn't exist. Use the Directus PUBLIC_URL env var to construct the endpoint URL directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qr-utils.tstoticket-utils.tsto better reflect its scope (ticket code generation, price formatting, QR buffers)buildTicketCardHtml/buildTicketListHtml— HTML is now fully managed in CMS email templatescidsupport to the shared email service attachment interface.pkpass) and Google Wallet (JWT URL) pass generation in a newwallet-pass-generator.tsutility/ticket-wallet/apple/:ticketCodeendpoint for on-demand.pkpassdownloads authenticated via profile tokenTest plan
.pkpasson iOS/Mac)ticket_profile_completedtemplate to use new variables (qr_code_cid,apple_wallet_url,google_wallet_url)🤖 Generated with Claude Code