Skip to content

Replace libsignal-protocol-c with libomemo-c#2020

Closed
jubalh wants to merge 4 commits intomasterfrom
patch/stefan
Closed

Replace libsignal-protocol-c with libomemo-c#2020
jubalh wants to merge 4 commits intomasterfrom
patch/stefan

Conversation

@jubalh
Copy link
Copy Markdown
Member

@jubalh jubalh commented Feb 21, 2025

The library libsignal-protocol-c is not maintained. This commit will replace the dependency libsignal-protocol-c with libomemo-c.

On 2025-02-07 a new version of protobuf-c has been uploaded to Debian. This new version induced a bug for libsignal-protocol-c and libomemo-c:

  • Bug#1095352: libomemo-c: FTBFS [1]
  • Bug#1095353: libsignal-protocol-c: FTBFS [2]

(Thanks to Dino team and Debian Maintainer it's solved)

libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained by the Dino team.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353
[3] https://github.com/dino/libomemo-c
[4] https://github.com/signalapp/libsignal-protocol-c

Note:
Commits squashed and commit message edited by @jubalh.

@jubalh jubalh added the cleanup label Feb 21, 2025
@jubalh
Copy link
Copy Markdown
Member Author

jubalh commented Feb 21, 2025

Received those patches via PM and mailinglist from Stefan.

Comments (to Stefan):
I squashed the two commits into 1. If you use 2 commits then the configure change should have been done with the same commit as changing the source files. Since otherwise it wouldn't build ;)
Then the CI changes could be a separate step.

Don't forget that we use present tense in commit messages (Replace not Replaced).

I also added the (quite valuable) info that you added to the email but not to the patch files themselves.

And CI sais no :)

@Neustradamus
Copy link
Copy Markdown

@jubalh: Nice! :)

Can you help to update libomemo-c to latest XEP-0384 version?

At this time: 0.8.3 (2022-01-18).

Ticket here:

Note: @Ri0n from @psi-im team has done a PR here:

@jubalh
Copy link
Copy Markdown
Member Author

jubalh commented Mar 12, 2025

@sjaeckel do we want an ifdef or just switch to libomemo-c?

@jubalh
Copy link
Copy Markdown
Member Author

jubalh commented Apr 8, 2025

@Neustradamus
Copy link
Copy Markdown

DebXWoody and others added 4 commits October 9, 2025 12:03
The library libsignal-protocol-c is not maintained. This commit will
replace the dependency libsignal-protocol-c with libomemo-c.

On 2025-02-07 a new version of protobuf-c has been uploaded to
Debian. This new version induced a bug for libsignal-protocol-c
and libomemo-c:

 * Bug#1095352: libomemo-c: FTBFS [1]
 * Bug#1095353: libsignal-protocol-c: FTBFS [2]

(Thanks to Dino team and Debian Maintainer it's solved)

libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained
by the Dino team.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353
[3] https://github.com/dino/libomemo-c
[4] https://github.com/signalapp/libsignal-protocol-c

Note:
Commits squashed and commit message edited by @jubalh.
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Let's just hope it never breaks its API and/or ABI.

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
@sjaeckel sjaeckel force-pushed the patch/stefan branch 2 times, most recently from 4dd4b1c to b4a1528 Compare October 9, 2025 10:05
jubalh added a commit that referenced this pull request Mar 19, 2026
Add the ability to choose between libsignal-protocol-c (default)
and libomemo-c when building with OMEMO support enabled in Meson.

Close: #2020
@jubalh jubalh closed this in 27b5f0f Mar 19, 2026
@jubalh jubalh deleted the patch/stefan branch March 19, 2026 18:53
@Neustradamus
Copy link
Copy Markdown

@jubalh: Thanks for your PR merging:

Merged commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants