Repository navigation
Add typography to model performance tests - #8993
Merged
Merged
Conversation
Contributor
Author
|
Hi @shakeelmohamed @ksen0 here is a PR for the #8970. I branch off the #8918 and once you are fine with this PR, I will leave a comment about one too there. Few notes about the changes:
|
2 of 17 tasks
3 tasks done
Resolve conflict in test/bench/typography.bench.js after processing#8918 was merged: keep main's harness (WebGPU addon registration, awaited WebGPU createCanvas) and re-apply the textToModel() benchmarks for WebGL and WebGPU on top of it.
Contributor
Author
|
Hi @shakeelmohamed @ksen0 @davepagurek, now that #8918 is merged, I've merged |
Continuous ReleaseCDN linkPublished PackagesCommit hash: 5d02081 Previous deploymentsThis is an automated message. |
davepagurek
approved these changes
Oct 6, 2026
davepagurek
left a comment
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks @michtesar!
Contributor
|
@all-contributors please add @michtesar for test |
Contributor
|
I've put up a pull request to add @michtesar! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8970
Changes:
This PR continues the typography benchmark work from #8918 (branched from #8918).
It adds
TO_MODEL_CASESusing the same strings, text sizes, sample factors, and rendering configurations as the existingtextToPoints()benchmarks. The new cases run with both WebGL and WebGPU.The WebGPU renderer addon is registered explicitly because
src/appdoes not include it. Without registration, the benchmark emits renderer errors and produces no validtextToModel()results.Benchmarks also verifies that the generated model contains vertices with asserts. This helps detect cases where the benchmark appears to run successfully without producing usable geometry (which it happened before I registered the WebGPU renderer).
Screenshots of the change:
New tests are running ok
PR Checklist
npm run lintpasses