fix: lerp colors in current color mode#8920
Open
pupuking723 wants to merge 1 commit into
Open
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: 10cf56d Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8883
Changes:
Color.lerp()interpolate in the explicit mode passed bylerpColor(), instead of interpolating in the source colors' original color space and only formatting the result in the current mode.lerpColor()expectations to match current-mode interpolation. I did not add a new regression test, following the maintainer request in [p5.js 2.0+ Bug Report]:lerpColor()not affected bycolorMode()#8883 to start with just the fix.Screenshots of the change:
Not applicable.
PR Checklist
npm run lintpassesVerification:
npm test -- --run test/unit/color/creating_reading.js test/unit/color/p5.Color.jsnpm run lintAI assistance disclosure: I used Codex assistively while preparing this change. I reviewed the issue discussion, source changes, test updates, and verification output myself, and I take responsibility for the PR.