[1.x] Update CI node version to 24#8852
Open
limzykenneth wants to merge 3 commits into
Open
Conversation
Contributor
|
Hey @limzykenneth! I pulled your branch locally to test this. The actual problem is that we have puppeteer pinned to ^18.2.1, which is from Oct 2022. This old version tries to download Chrome revision |
Member
Author
|
The test is not passing with latest version of puppeteer. Since this is 1.x, we'll not spend too much time updating it, I'll just update CI to use Node 22 for now. |
Contributor
|
Makes sense! In the meantime, I can look into this more deeply and I'll try to understand why tests are failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
All CI now runs Node.js 24 where needed, this should have LTS for quite awhile yet