Skip to content

Suppress stroke warnings during buildGeometry#8411

Merged
davepagurek merged 1 commit intoprocessing:mainfrom
skyash-dev:fix/suppress-stroke-warning-buildGeometry
Jan 23, 2026
Merged

Suppress stroke warnings during buildGeometry#8411
davepagurek merged 1 commit intoprocessing:mainfrom
skyash-dev:fix/suppress-stroke-warning-buildGeometry

Conversation

@skyash-dev
Copy link
Contributor

@skyash-dev skyash-dev commented Jan 13, 2026

Addresses #8387

Changes:
Suppresses high-detail stroke warnings while geometry is being constructed via buildGeometry() / beginGeometry().
During geometry construction, p5.js cannot yet know whether the resulting geometry will be rendered with strokes, so emitting warnings at that stage can be misleading. The warning behavior during normal drawing remains unchanged.

PR Checklist

  • npm run lint passes
  • [Inline reference] is included / updated
  • [Unit tests] are included / updated

@welcome
Copy link

welcome bot commented Jan 13, 2026

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@davepagurek
Copy link
Contributor

Thanks for making this! Right now it's still using console.log so this will show up even though p5.disableFriendlyErrors = true is set. Do you think we could update it to go through FES's logger?

@davepagurek
Copy link
Contributor

Discussed some more in the issue, there isnt actually a warning logger yet, so we're going to leave this as is for main but set up something for that in dev-2.0.

@davepagurek davepagurek merged commit c0513a3 into processing:main Jan 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants