test: add regression tests for color.toString('#rrggbb')#8369
Closed
sidhansu10 wants to merge 1 commit intoprocessing:mainfrom
Closed
test: add regression tests for color.toString('#rrggbb')#8369sidhansu10 wants to merge 1 commit intoprocessing:mainfrom
sidhansu10 wants to merge 1 commit intoprocessing:mainfrom
Conversation
perminder-17
reviewed
Jan 4, 2026
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
I'll be closing this PR since it's already assigned to other contributor and the PR is already opened: #8363, thanks for your work and patience at this PR.
Author
|
Thanks for letting me know, no worries at all. Glad to hear the issue is already being handled in #8363. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds regression tests for
p5.Color.prototype.toString('#rrggbb')to ensure hex formatting is preserved across named colors, hex input,
and RGB input.
These tests encode the expected behavior from p5.js v1.x and help guard
against the regression observed in p5.js 2.x.
Related issue: #8284