Open
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8097
Changes:
This PR adds a new
activeCamera()function that provides a standard joint getter/setter API for accessing and modifying the current active camera in p5.js WebGL mode.Implementation Details:
Added
activeCamera()function: A joint getter/setter that follows the pattern used by other p5.js functions likelinePerspective()p5.Cameraobjectthisfor chaining_assert3d()validation to ensure it's only used in WebGL modeAdded
RendererGL.prototype.activeCamera()method: Implements the same getter/setter pattern at the renderer level, reusing existingsetCamera()logicComprehensive test suite: Added 5 test cases covering:
Benefits:
setCamera()functionFiles Modified:
src/webgl/p5.Camera.js: Addedfn.activeCamera()andRendererGL.prototype.activeCamera()with full JSDoc documentation and examplestest/unit/webgl/p5.Camera.js: Added comprehensive test suite foractiveCamera()functionalityScreenshots of the change:
N/A - This is a code-only change that adds a new API function. No visual changes.
PR Checklist
npm run lintpassesInline reference is included / updated
Unit tests are included / updated