chore: add missing Hindi translations for homepage & UI elements#1016
chore: add missing Hindi translations for homepage & UI elements#1016ksen0 merged 5 commits intoprocessing:mainfrom
Conversation
|
Hi @Divyansh013 and @takshittt, is one of you able to take a look at this and check the translations, please? Thank you! |
|
@ksen0 Hi, Can I review this PR as I'm native hindi speaker. |
I will take a look! Sorry for the delay |
| referenceHeaderText: p5.js कोड के प्रत्येक भाग के लिए आसान व्याख्या ढूंढें। | ||
| examplesHeaderText: छोटे उदाहरणों के साथ p5.js की संभावनाओं का पता लगाएं। | ||
| communityHeaderText: देखें कि दुनिया भर के लोग |
There was a problem hiding this comment.
Hi @3Sangeetha3 ,the translations here seems a bit off compared to what it actually says. You can see the current translation to check what we are currently using for words like reference and community. Also in line 43, it means see the p5.js community and not the people from entire world. Let me know if you need any help
There was a problem hiding this comment.
Hi @Divyansh013, thanks for the review!
I’ve updated the translations to align with the existing terminology and corrected the community wording as suggested. Please take another look and let me know if anything else needs adjustment. Thanks!
There was a problem hiding this comment.
Pull request overview
This PR enhances the Hindi localization of the p5.js website by translating UI text that previously appeared in English. The changes address issue #1015, which reported incomplete Hindi translations causing a mixed English/Hindi experience on the /hi/ route.
Changes:
- Added Hindi translations for homepage header texts and UI elements
- Converted hardcoded "Welcome to p5.js" text to use translation function
- Added new translation keys to both English and Hindi UI files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/layouts/HomepageLayout.astro | Changed hardcoded "Welcome to p5.js" text to use translation function t("Welcome to p5.js") |
| src/content/ui/hi.yaml | Added Hindi translations for "Welcome to p5.js", "Skip to main content", "Menu", and "Download Library" |
| src/content/ui/en.yaml | Added English translation keys for "Welcome to p5.js" and "Skip to main content" |
| src/content/homepage/hi.yaml | Translated homepage header texts (referenceHeaderText, examplesHeaderText, communityHeaderText) from English to Hindi |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,6 @@ | |||
| Home: Home | |||
| Welcome to p5.js: Welcome to p5.js | |||
| Skip to main content: Skip to main content | |||
There was a problem hiding this comment.
Missing translation key "Download Library" in the English translations. This key is used in HomepageLayout.astro (line 99) and is present in the Hindi translations (hi.yaml line 14), but is not defined in en.yaml. This will cause the translation system to fail to find the key when rendering the English version of the homepage. Add the key after this line: "Download Library: Download Library"
This PR enhances the Hindi localization of the p5.js website by translating UI text that previously appeared in English on the /hi/ route. The goal is to provide a complete and consistent user experience for Hindi-speaking users.
📎 Related Issue
Closes #1015
📌 Changes Made
📍 Why
🔍 Screenshots
🧪 Testing
📝 Notes
Let me know if any wording changes or translation improvements are required — happy to update.