Skip to content

Fix: Non-Clickable File Menus On Hover Refactor#4145

Open
runningonsideprojects wants to merge 4 commits into
processing:developfrom
runningonsideprojects:non-clickable-file-menu-refactor
Open

Fix: Non-Clickable File Menus On Hover Refactor#4145
runningonsideprojects wants to merge 4 commits into
processing:developfrom
runningonsideprojects:non-clickable-file-menu-refactor

Conversation

@runningonsideprojects
Copy link
Copy Markdown
Collaborator

@runningonsideprojects runningonsideprojects commented Jun 3, 2026

Issue:

Fixes #4121

This PR addresses the File Menu options to ensure adherance to WCAG guidelines and to improve better UX for disabled options.

HUGEEE shoutout to @Nixxx19 for helping me fix a weird scss inheritance issue!!!!!

Demo:

Screenshots of changes in light, dark, and contrast mode

Screenshot 2026-06-02 at 11 33 04 PM Screenshot 2026-06-02 at 11 35 05 PM Screenshot 2026-06-02 at 11 35 18 PM

QA Testing:

  1. Navigate to the home page.
  2. Click on the File menu at the top left
  3. Make sure u are not logged in
  4. For [light, dark, contrast] mode, ensure ....
  • the same menu options are disabled
  • the disabled menu options have the 🚫 cursor, the background is not highlighted, but the tooltip is still there.
  • active menu options still function normally

Changes:

  • cursor: not-allowed; on disabled menu items
  • gets rid of the background color change and text color change on disabled items on hover
  • new variable button-hover-active-color that changes the active menu color on light mode to $darker ($1C1C1C)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@runningonsideprojects runningonsideprojects force-pushed the non-clickable-file-menu-refactor branch from 474ec8f to 9cd2572 Compare June 3, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling Refactor on Non Clickable Options of File Menu

1 participant