fix: rename blog assets with Windows incompatible filenames - #8089
Open
akshy-rai wants to merge 9 commits into
Open
fix: rename blog assets with Windows incompatible filenames#8089akshy-rai wants to merge 9 commits into
akshy-rai wants to merge 9 commits into
Conversation
|
@akshy-rai is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (56)
📒 Files selected for processing (18)
🚧 Files skipped from review as they are similar to previous changes (16)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughUpdated image and GIF asset references across blog MDX articles. Corrected matching filenames in the asset optimization report. The REST API tutorial also updates its GraphQL Playground screenshots and explanatory text. ChangesBlog asset path corrections
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change updates blog asset paths to Windows-compatible filenames, preventing checkout failures without introducing an identified runtime or content-serving risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The PR objective matches issue Resolution Include the affected files under apps/blog/public in the review, or provide an unfiltered diff that confirms removal of the asterisk-named asset and addition of apps/blog/public/connections-edges-nodes-in-relay-758d358aa4c7/imgs/0-sPafc6eXHJvRSJhZ.png. Full details: Out of Scope Changes checkExplanation Most changes update image references and the asset report, which support the stated objective. The reported change from “let’s” to “lets” in how-to-wrap-a-rest-api-with-graphql is unrelated to the asset rename objective.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/blog/content/blog/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/index.mdx`:
- Around line 414-416: Correct the GraphQL Playground description by changing
“that let’s you explore” to “that lets you explore,” preserving the surrounding
explanation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ed219bfa-3974-4bfd-823c-368305d3d474
⛔ Files ignored due to path filters (56)
apps/blog/public/connections-edges-nodes-in-relay-758d358aa4c7/imgs/0-sPafc6eXHJvRSJhZ.pngis excluded by!**/*.pngapps/blog/public/enabling-cors-for-express-graphql-apollo-server-1ef999bfb38d/imgs/1-LnVsDQuQtSl-Wt-m6DfO5g.pngis excluded by!**/*.pngapps/blog/public/enabling-cors-for-express-graphql-apollo-server-1ef999bfb38d/imgs/1-ZbsVGATAeIp5iU2504VP2A.pngis excluded by!**/*.pngapps/blog/public/enabling-cors-for-express-graphql-apollo-server-1ef999bfb38d/imgs/1-m6QGz5tXtLt7uVapNCpBEw.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-A92lc0WjBQD120DC.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-KQLRnImerQRjALS5.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-QelKIjXtM12d3kAe.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-h_JXfmCfcMYpbO__.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-iPceJCV7B-ri4upn.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-lWBTpLYdMBLe7BvS.pngis excluded by!**/*.pngapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-p_mSrJU2L90IXDSi.jpgis excluded by!**/*.jpgapps/blog/public/getting-started-with-relay-modern-46f8de6bd6ec/imgs/0-t5Y1tsH07bEQHbrB.pngis excluded by!**/*.pngapps/blog/public/graphql-eu-18-eiw8bishe2di/imgs/1--iELVZWzvAgEaKZlkNU6ZA.pngis excluded by!**/*.pngapps/blog/public/graphql-eu-18-eiw8bishe2di/imgs/1-AN2VR8MNLpLeNzUOEGbCJA.pngis excluded by!**/*.pngapps/blog/public/graphql-eu-18-eiw8bishe2di/imgs/1-_QMKg1HIi96OtzMMOtoajQ@2x.pngis excluded by!**/*.pngapps/blog/public/graphql-eu-18-eiw8bishe2di/imgs/1-f3CIuLP_Lr3Q0UYNsP5lvQ.jpegis excluded by!**/*.jpegapps/blog/public/graphql-eu-18-eiw8bishe2di/imgs/1-kKq-QXjiDhsDi82ZK8OX8w.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-demystifying-the-info-argument-in-graphql-resolvers-6f26249f613a/imgs/1-2UStyS7v3NIZKl2cLsBtYA.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-the-network-layer-51d97d21861/imgs/1-0ZgAAtT0Zm-Kc63SNeT5Ew.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-the-network-layer-51d97d21861/imgs/1-6ERw4Znf6UYou_epNUutRA.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-the-network-layer-51d97d21861/imgs/1-dMyX0jnoKvhYAa0cgSqenQ.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-the-network-layer-51d97d21861/imgs/1-yIYI_iNabiNS_7uuzFVJDQ.pngis excluded by!**/*.pngapps/blog/public/graphql-server-basics-the-schema-ac5e2950214e/imgs/1-_fQh0zWBlDG1OJ-FbMnWcw.pngis excluded by!**/*.pngapps/blog/public/how-do-graphql-remote-schemas-work-7118237c89d7/imgs/1-KQ620d8vVrnl4vCYyqkWOA.pngis excluded by!**/*.pngapps/blog/public/how-do-graphql-remote-schemas-work-7118237c89d7/imgs/1-SwVWiWOCRnyCCP80lKoXjw.pngis excluded by!**/*.pngapps/blog/public/how-do-graphql-remote-schemas-work-7118237c89d7/imgs/1-bz9k7dsElF5x_eqIfc_XWw.pngis excluded by!**/*.pngapps/blog/public/how-do-graphql-remote-schemas-work-7118237c89d7/imgs/1-nmcFbnUg7ooxjlZ8z-GLQA.pngis excluded by!**/*.pngapps/blog/public/how-do-graphql-remote-schemas-work-7118237c89d7/imgs/1-o57PeaoF5PVrON-FhR8QTA.pngis excluded by!**/*.pngapps/blog/public/how-to-use-create-react-app-with-graphql-apollo-62e574617cff/imgs/0-MZcp4O86JEoMbtpi.pngis excluded by!**/*.pngapps/blog/public/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/imgs/1-0mbKo-p6qfrBKgAaJb0gOQ.pngis excluded by!**/*.pngapps/blog/public/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/imgs/1-UF5m7oNBcs1LKPboj7GQ8A.pngis excluded by!**/*.pngapps/blog/public/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/imgs/1-m5LM8FgXa0VEMz-KwMyd3Q.pngis excluded by!**/*.pngapps/blog/public/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/imgs/1-sGvSvA1yKloKDpXNb3jfBw.pngis excluded by!**/*.pngapps/blog/public/improving-performance-with-apollo-query-batching-66455ea9d8b/imgs/0--h6XwUanLrNSYjJk.pngis excluded by!**/*.pngapps/blog/public/improving-performance-with-apollo-query-batching-66455ea9d8b/imgs/0-5vAu8GPtx3kpYcX9.pngis excluded by!**/*.pngapps/blog/public/improving-performance-with-apollo-query-batching-66455ea9d8b/imgs/0-eqlu9eJJgj8vIqck.pngis excluded by!**/*.pngapps/blog/public/improving-performance-with-apollo-query-batching-66455ea9d8b/imgs/0-mv6z4N7_OSza7_2h.pngis excluded by!**/*.pngapps/blog/public/new-tooling-to-improve-your-graphql-workflows-7240c81e1ba3/imgs/0-c56E4V22_pl88Si4.gifis excluded by!**/*.gifapps/blog/public/new-tooling-to-improve-your-graphql-workflows-7240c81e1ba3/imgs/0-zy8sNGj9yqANZhrw.pngis excluded by!**/*.pngapps/blog/public/prisma-raises-4-5m-to-build-the-graphql-data-layer-for-all-databases-663484df0f60/imgs/1-MmTqUD1_jQtNRxsMhyQyDg@2x.pngis excluded by!**/*.pngapps/blog/public/top-5-reasons-to-use-graphql-b60cfa683511/imgs/1-OPs5D2XrAcFI1hDay-_nEQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/imgs/1-1vMUL8w54yIAxOPVSR0UjQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/imgs/1-9fDpnhWdRrgN-vxB3HmLeQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/imgs/1-GoxKn35GhQpmHZ6bnKbDZA.pngis excluded by!**/*.pngapps/blog/public/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/imgs/1-TisP6j41cu4itqI__dDE-w.pngis excluded by!**/*.pngapps/blog/public/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/imgs/1-c6bexq2J0bTeT5UioGjl_A.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-3fi7Zud_T3VeocM7CN_FIQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-_EjTITNbwXGCVc7f5MA7tQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-dgGQ6f1SZcJH7nddNM0Kug.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-iNK392MZ7rLIemoigPtvGA.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-idRITgkP04XGflQExvz61A.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-ifNy0EWA5EdrqkU0X9LT3Q.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-rzI7PLKuJuRjjBIxoSiboQ.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-wBWEMQXeDUu6JZBN44ZGUg-1.pngis excluded by!**/*.pngapps/blog/public/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/imgs/1-wBWEMQXeDUu6JZBN44ZGUg.pngis excluded by!**/*.pngapps/blog/public/tutorial-using-create-react-native-app-with-graphql-apollo-e630aee3ae1e/imgs/0-A9dtztGpco-x9gTF.pngis excluded by!**/*.png
📒 Files selected for processing (18)
apps/blog/content/blog/connections-edges-nodes-in-relay-758d358aa4c7/index.mdxapps/blog/content/blog/enabling-cors-for-express-graphql-apollo-server-1ef999bfb38d/index.mdxapps/blog/content/blog/getting-started-with-relay-modern-46f8de6bd6ec/index.mdxapps/blog/content/blog/graphql-eu-18-eiw8bishe2di/index.mdxapps/blog/content/blog/graphql-server-basics-demystifying-the-info-argument-in-graphql-resolvers-6f26249f613a/index.mdxapps/blog/content/blog/graphql-server-basics-the-network-layer-51d97d21861/index.mdxapps/blog/content/blog/graphql-server-basics-the-schema-ac5e2950214e/index.mdxapps/blog/content/blog/how-do-graphql-remote-schemas-work-7118237c89d7/index.mdxapps/blog/content/blog/how-to-use-create-react-app-with-graphql-apollo-62e574617cff/index.mdxapps/blog/content/blog/how-to-wrap-a-rest-api-with-graphql-8bf3fb17547d/index.mdxapps/blog/content/blog/improving-performance-with-apollo-query-batching-66455ea9d8b/index.mdxapps/blog/content/blog/new-tooling-to-improve-your-graphql-workflows-7240c81e1ba3/index.mdxapps/blog/content/blog/prisma-raises-4-5m-to-build-the-graphql-data-layer-for-all-databases-663484df0f60/index.mdxapps/blog/content/blog/top-5-reasons-to-use-graphql-b60cfa683511/index.mdxapps/blog/content/blog/tutorial-building-a-realtime-graphql-server-with-subscriptions-2758cfc6d427/index.mdxapps/blog/content/blog/tutorial-render-props-in-react-apollo-2-1-199e9e2bd01e/index.mdxapps/blog/content/blog/tutorial-using-create-react-native-app-with-graphql-apollo-e630aee3ae1e/index.mdxasset-optimization-report.md
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7899
Some image assets under
apps/blog/publiccontained*characters in their filenames.While these filenames work on Unix-based systems, they are invalid on Windows and cause
git clone/git checkoutto fail.This PR renames those assets by replacing
*with-so the repository can be checked out on Windows environments.Changes made
*in their filenamesTesting
Summary by CodeRabbit