Skip to content

[MCP] Improvement for motion tokens #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerJDev merged 2 commits into from
Mar 6, 2026
Merged

[MCP] Improvement for motion tokens #7632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8385924
improvement for motion tokens
lukasoppermann Mar 6, 2026
86ba5cc
add changeset
lukasoppermann Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-carpets-bake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/mcp': patch
---

Add motion and animation token support to MCP design token search, including `animation` and `duration` semantic prefixes, transition usage hints, and updated optimization recipes
21 changes: 17 additions & 4 deletions packages/mcp/src/primitives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,17 @@ function serialize(value: typeof tokens): string {
}

// Semantic group prefixes that apply to any element
const SEMANTIC_PREFIXES = ['bgColor', 'fgColor', 'border', 'borderColor', 'shadow', 'focus', 'color']
const SEMANTIC_PREFIXES = [
'bgColor',
'fgColor',
'border',
'borderColor',
'shadow',
'focus',
'color',
'animation',
'duration',
]

type TokenGroup = {
name: string
Expand Down Expand Up @@ -423,6 +433,7 @@ function getDesignTokenSpecsText(groups: TokenGroups): string {

## 1. Core Rule & Enforcement
* **Expert Mode**: CSS expert. NEVER use raw values (hex, px, etc.). Tokens only.
* **Motion & Transitions:** Every interactive state change (Hover, Active) MUST include a transition. NEVER use raw values like 200ms or ease-in. Use var(--base-duration-...) and var(--base-easing-...).
* **Shorthand**: MUST use \`font: var(...)\`. NEVER split size/weight.
* **Shorthand Fallback**: If no shorthand exists (e.g. Monospace), use individual tokens for font-size, family, and line-height. NEVER raw 1.5.
* **States**: Define 5: Rest, Hover, Focus-visible, Active, Disabled.
Expand All @@ -448,10 +459,10 @@ function getDesignTokenSpecsText(groups: TokenGroups): string {

## 4. Optimization & Recipes (MANDATORY)
**Strategy**: STOP property-by-property searching. Use \`get_token_group_bundle\` for these common patterns:
- **Forms**: \`["control", "focus", "outline", "text", "borderRadius", "stack"]\`
- **Modals/Cards**: \`["overlay", "shadow", "outline", "borderRadius", "bgColor", "stack"]\`
- **Forms**: \`["control", "focus", "outline", "text", "borderRadius", "stack", "animation"]\`
- **Modals/Cards**: \`["overlay", "shadow", "outline", "borderRadius", "bgColor", "stack", "animation"]\`
- **Tables/Lists**: \`["stack", "borderColor", "text", "bgColor", "control"]\`
- **Nav/Sidebars**: \`["control", "text", "accent", "stack", "focus"]\`
- **Nav/Sidebars**: \`["control", "text", "accent", "stack", "focus", "animation"]\`
- **Status/Badges**: \`["text", "success", "danger", "attention", "severe", "stack"]\`

## 5. Available Groups
Expand Down Expand Up @@ -720,6 +731,8 @@ const groupHints: Record<string, string> = {
fgColor: 'Use `fgColor` for text. For borders, use `borderColor`.',
borderWidth:
'`borderWidth` only has sizing values (thin, thick, thicker). For border *colors*, use the `borderColor` or `border` group.',
animation:
'TRANSITION RULE: Apply duration and easing to the base class, not the :hover state. Standard pairing: `transition: background-color var(--base-duration-200) var(--base-easing-easeInOut);`',
}

// -----------------------------------------------------------------------------
Expand Down
Loading