Skip to content

feat: support nonmonotonic increment#261

Closed
34j wants to merge 1 commit intopre-commit:mainfrom
34j:feat/nonlinear-increment
Closed

feat: support nonmonotonic increment#261
34j wants to merge 1 commit intopre-commit:mainfrom
34j:feat/nonlinear-increment

Conversation

@34j
Copy link

@34j 34j commented Mar 1, 2026

No description provided.

@asottile
Copy link
Member

asottile commented Mar 1, 2026

yeah this clearly doesn't work

@asottile asottile closed this Mar 1, 2026
@34j
Copy link
Author

34j commented Mar 1, 2026

It works: https://github.com/34j/mirrors-prettier

@34j 34j changed the title feat: support nonlinear increment feat: support nonmonotonic increment Mar 1, 2026
@asottile
Copy link
Member

asottile commented Mar 1, 2026

yeah? tests disagree

@34j
Copy link
Author

34j commented Mar 1, 2026

Because I was too lazy to update tests 😅, sorry but thanks for your comment

  • tests/make_repo_test.py::test_commit_version fails because .version is not updated in _commit_version now (maybe design mistake)
  • tests/make_repo_test.py::test_make_repo_starting_empty fails because of the added feature

@asottile
Copy link
Member

asottile commented Mar 1, 2026

well then you've missed the entire point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants