pg_query_state code should be stable to the struct LOCKTAG extension. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOCKTAG is used in hash calculations, so if new field is added to LOCKTAG and this field is not initialized in pg_query_state internals, as the result, the hashcode of LOCKTAG will have different values for two independent calculations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 71.25% 71.21% -0.05%
==========================================
Files 8 8
Lines 668 667 -1
==========================================
- Hits 476 475 -1
Misses 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOCKTAG is used in hash calculations, so if new field is added to LOCKTAG and this field is not initialized in pg_query_state internals, as the result, the hashcode of LOCKTAG will have different values for two independent calculations.