Work around @_exported-public import bug#477
Merged
Merged
Conversation
We've relied on fine-grained GRDB exports via, e.g.: ```swift @_exported import class GRDB.Database ``` This underscored feature unfortunately doesn't always seem to play nicely with Swift's upcoming features around member visibility and internal imports. While I can't always reproduce the issue, I have been able to do so in the Reminders app, which had some explicit imports to work around the issue. This commit updates things to use `public typealias` for aliasing instead, which does not appear to cause ambiguity when an `import GRDB` is done in the same file. This is also how some of Apple's packages handle the same problem.
mbrandonw
approved these changes
Jun 9, 2026
mbrandonw
reviewed
Jun 10, 2026
This reverts commit e0bc4c6.
stephencelis
changed the title
@_exported-public import bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've relied on fine-grained GRDB exports via, e.g.:
But it turns out this breaks as soon as you have an explicit
public importin the same module:To work around this bug, we can use
#ifblocks to make each mutually exclusive.