Conversation
|
@gvwilson big picture comments --
|
af41d30 to
9c60129
Compare
|
What would you think of adding an item to the pull request template documentations section that recommends: [ ] start Python code blocks with ```python? It's something that is not obvious in the checklist and that I've forgotten to do a couple times. Forgetting to do so can prevent the example from displaying. |
- Run `ruff format --check .` instead of `ruff format .` in Circle CI. - Use `base_type is list` instead of `base_type == list`. - Remove commented-out lines of code. - Remove unnecessary parentheses around some strings. - Be more consistent about (re-)naming test functions that had duplicated names. - Use `noqa: F401` to suppress `ruff check` complaint about unused import.
requires-optional.txtandtest_requirements/*(no longer used).commands.pyto useargparseinstead of hand-rolled.codegen/__init__.py(all at top level)."dev"section ofpyproject.tomlto useruffinstead ofblack.pyproject.tomlto installinflectandrequests.uv.lockfile.codegen/__init__.pyto useruffinstead ofblack.ruffto reformat existing code (runpython commands.py format).ruffto check code (runpython commands.py lint).This PR has been rebuilt on top of #5214 to include recent changes to validator generation.
This PR currently fails the build because Circle CI is expecting
requires-optional.txt, which this PR removes.We need to decide if we're leaving build on Circle CI or moving it to GitHub.