Add environment type and fix Config::onProduction#22
Closed
andrewbelcher wants to merge 1 commit intoplatformsh:masterfrom
Closed
Add environment type and fix Config::onProduction#22andrewbelcher wants to merge 1 commit intoplatformsh:masterfrom
andrewbelcher wants to merge 1 commit intoplatformsh:masterfrom
Conversation
andrewbelcher
changed the title
damz
suggested changes
Feb 1, 2022
damz
left a comment
damz
left a comment
There was a problem hiding this comment.
Hi Andrew 👋
Thanks for opening this. This looks like an decent improvement to me, but see the inline comment about a backwards compatibility issue.
| $prodBranch = $this->onDedicated() ? 'production' : 'master'; | ||
|
|
||
| return $this->getValue('BRANCH') == $prodBranch; | ||
| return $this->getValue('ENVIRONMENT_TYPE') == 'production'; |
There was a problem hiding this comment.
It looks like some legacy environments will not have that variable, so we need to keep the current logic as backwards compatibility here.
flovntp
approved these changes
Jul 12, 2023
|
Friendly ping. I really wanted to use My best workaround is just doing |
Contributor
|
Cross posting that this PR did not address the backwards compatibility issue, but this PR does |
|
Closing in favor of #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21