Conversation
|
@wesleytodd can we move on with this? Also, I think this is not a breaking change, is it? |
|
I am fine doing it as minor, and yeah we can move on it, I just have not had time to test and make sure everything was good, nor do the release. Do you have perms do to all that? If not, and I am this delayed again circling back feel free to ping me in slack. |
|
I am probably unable to make these updates, but I agree with them. If someone wants to take this over feel free. |
|
It always comes back around. I am going to pick up #34 in the next month and so will try to make these updates and land it to include in that. Let me know if anyone has any other feedback and I will try to incorporate it. |
|
Rebased |
While the tests pass and it all seems fine, the
cachekey used to be aMapforgotto use. Now it is just a simple in memory lookup. Same api to pass, but technically someone could have been looking at the contents of the map they passed in, so this could break them so marking it as major.