Skip to content

fix: resolve Svelte(Kit) favicons#4448

Open
VitroidFPV wants to merge 1 commit into
pingdotgg:mainfrom
VitroidFPV:svelte-sidebar-icons
Open

fix: resolve Svelte(Kit) favicons#4448
VitroidFPV wants to merge 1 commit into
pingdotgg:mainfrom
VitroidFPV:svelte-sidebar-icons

Conversation

@VitroidFPV

@VitroidFPV VitroidFPV commented Jul 24, 2026

Copy link
Copy Markdown

What Changed

Favicons in default Svelte/SvelteKit directories get resolved to be displayed in the sidebar.

Why

The SvelteKit Tutorial and demo template places favicons in static/, and the minimal template uses src/lib/assets/. Neither of those two paths were previously resolved, showing as blank folders in the sidebar.

#1613 was closed due to inactivity and conflicts. This PR is a tighter-focused re-implementation - it adds PNG, SVG and ICO favicons in those two directories to the list in ProjectFaviconResolver.ts, tests for the newly added favicon directories, and makes path assertions in the tests be Windows-safe, in line with many other tests.

UI Changes

Before/After

t3-code-before t3-code-after

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Add Svelte and SvelteKit favicon paths to FAVICON_CANDIDATES

Extends the well-known favicon candidate list in ProjectFaviconResolver.ts to include static/favicon.(svg|ico|png) (after public/) and src/lib/assets/favicon.(svg|ico|png) (after src/favicon.*), covering standard Svelte and SvelteKit project layouts. Tests are updated to assert strict path equality using path.join(cwd, relativePath).

Macroscope summarized 42a6f71.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 356eb335-c6a1-4ae4-b9ca-0d9d0480e72a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 24, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Adds 6 new SvelteKit favicon path candidates to an existing array, with corresponding parameterized tests. Purely additive change with no impact on existing behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge enabled auto-merge (squash) July 24, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant