Skip to content

fix(web): align remote server update action#4430

Open
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/fix-remote-update-button-alignment
Open

fix(web): align remote server update action#4430
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/fix-remote-update-button-alignment

Conversation

@StiensWout

@StiensWout StiensWout commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move the remote server update control into the row's right-aligned action rail
  • keep the version-drift warning in the content column
  • render the update action only while a version mismatch exists
  • preserve the existing semantic warning and button tokens in light and dark themes

Root cause

ServerUpdateAction was rendered inline beside the version-drift message, while Disconnect lived in the row's dedicated action column. The two controls therefore used unrelated alignment contexts.

Validation

  • corepack pnpm exec vp fmt --check apps/web/src/components/settings/ConnectionsSettings.tsx
  • corepack pnpm exec vp lint apps/web/src/components/settings/ConnectionsSettings.tsx --report-unused-disable-directives
  • corepack pnpm exec vp run --filter @t3tools/web typecheck
  • corepack pnpm exec vp test run src/components/ServerUpdateAction.test.tsx --project unit from apps/web (3 tests passed)
  • isolated web verification against a live mismatched remote backend in light and dark themes
  • verified the real Updating... state keeps the update and disconnect controls aligned
  • verified a matching-version remote renders neither the drift warning nor an update action

Screenshots

Theme Before After
Light Before in light mode After in light mode
Dark Before in dark mode After in dark mode

Note

Move server update action button to the actions area in remote server list rows

In SavedBackendListRow, the ServerUpdateAction button was previously rendered inline with the version drift warning text. It is now rendered in the right-side actions section alongside other row action buttons, matching the layout of the rest of the row.

Macroscope summarized eddf862.


Note

Low Risk
Pure UI repositioning in Connections settings with no logic or API changes.

Overview
In saved remote environment rows (SavedBackendListRow), the version-drift warning stays in the left content column, but ServerUpdateAction is moved into the right-aligned action rail next to Connect/Disconnect/Remove.

The update control still renders only when versionMismatch is set; props and behavior are unchanged—this is a layout alignment fix so the update button lines up with other row actions (including during Updating…).

Reviewed by Cursor Bugbot for commit eddf862. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 20c99f1c-d230-45ae-8291-5a3898e65985

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 24, 2026
@StiensWout
StiensWout marked this pull request as ready for review July 24, 2026 06:24
@macroscopeapp

macroscopeapp Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR relocates the ServerUpdateAction component for better visual alignment without changing its props or behavior. A purely cosmetic layout change with no runtime impact.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant