fix(web): align remote server update action#4430
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This PR relocates the ServerUpdateAction component for better visual alignment without changing its props or behavior. A purely cosmetic layout change with no runtime impact. You can customize Macroscope's approvability policy. Learn more. |
Summary
Root cause
ServerUpdateActionwas rendered inline beside the version-drift message, whileDisconnectlived in the row's dedicated action column. The two controls therefore used unrelated alignment contexts.Validation
corepack pnpm exec vp fmt --check apps/web/src/components/settings/ConnectionsSettings.tsxcorepack pnpm exec vp lint apps/web/src/components/settings/ConnectionsSettings.tsx --report-unused-disable-directivescorepack pnpm exec vp run --filter @t3tools/web typecheckcorepack pnpm exec vp test run src/components/ServerUpdateAction.test.tsx --project unitfromapps/web(3 tests passed)Updating...state keeps the update and disconnect controls alignedScreenshots
Note
Move server update action button to the actions area in remote server list rows
In
SavedBackendListRow, theServerUpdateActionbutton was previously rendered inline with the version drift warning text. It is now rendered in the right-side actions section alongside other row action buttons, matching the layout of the rest of the row.Macroscope summarized eddf862.
Note
Low Risk
Pure UI repositioning in Connections settings with no logic or API changes.
Overview
In saved remote environment rows (
SavedBackendListRow), the version-drift warning stays in the left content column, butServerUpdateActionis moved into the right-aligned action rail next to Connect/Disconnect/Remove.The update control still renders only when
versionMismatchis set; props and behavior are unchanged—this is a layout alignment fix so the update button lines up with other row actions (including during Updating…).Reviewed by Cursor Bugbot for commit eddf862. Bugbot is set up for automated code reviews on this repo. Configure here.