logservice: fix event store on disk size overflow#4063
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Feb 13, 2026
Merged
Conversation
Clamp negative Compact.InProgressBytes before casting to uint64 to prevent ticdc_event_store_on_disk_data_size from reporting EiB-scale spikes. Closes pingcap#4062 Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
ti-chi-bot
bot
added
release-note
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
wk989898
approved these changes
Feb 2, 2026
ti-chi-bot
bot
added
needs-1-more-lgtm
3AceShowHand
approved these changes
Feb 13, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Collaborator
Author
|
/check-issue-triage-complete |
Collaborator
Author
|
/test light |
Collaborator
Author
|
/test heavy |
Collaborator
Author
|
/cla |
Collaborator
Author
|
/retest |
This was referenced Feb 24, 2026
lidezhu
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4062
What is changed and how it works?
pebble.Metrics.Compact.InProgressByteswhen calculating event store disk usage to avoid uint64 wraparound.diskSpaceUsage.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. This only affects metric calculation and adds one conditional check.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note