Skip to content

docs: update PLAN REPLAYER object storage behavior#22557

Open
zeminzhou wants to merge 24 commits intopingcap:masterfrom
zeminzhou:docs/plan-replayer-object-storage-reopen
Open

docs: update PLAN REPLAYER object storage behavior#22557
zeminzhou wants to merge 24 commits intopingcap:masterfrom
zeminzhou:docs/plan-replayer-object-storage-reopen

Conversation

@zeminzhou
Copy link
Copy Markdown
Contributor

@zeminzhou zeminzhou commented Mar 12, 2026

What is changed, added or deleted? (Required)

This PR replaces #22548 because the original PR can no longer be reopened.

Update the PLAN REPLAYER documentation to reflect the new object storage behavior introduced in TiDB:

  • document that PLAN REPLAYER can store generated files in the storage configured by tidb_cloud_storage_uri
  • clarify that PLAN REPLAYER DUMP now returns either a file token or a presigned URL depending on the backend capability
  • document the corresponding download flow and presigned URL validity
  • clarify that PLAN REPLAYER CAPTURE files can also be stored in external storage while the token column still records the file token
  • update related system variable descriptions in system-variables.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

This documentation update is based on the following TiDB PRs:

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Mar 12, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TiDB documentation for the PLAN REPLAYER feature to accurately reflect its enhanced object storage capabilities. It details how PLAN REPLAYER can now utilize external cloud storage, the new dual output options (file token or presigned URL) for PLAN REPLAYER DUMP, and the corresponding download procedures. These changes ensure that users have up-to-date information regarding file storage, retrieval, and the role of the tidb_cloud_storage_uri system variable.

Highlights

  • External Storage Support: The PLAN REPLAYER feature now supports storing generated files in external storage, configured via the tidb_cloud_storage_uri system variable.
  • Flexible Output for DUMP: PLAN REPLAYER DUMP can now return either a file token or a presigned URL, depending on the capabilities of the configured storage backend.
  • Enhanced Download Guidance: The documentation provides clear instructions for downloading files using both file tokens and presigned URLs, including details on presigned URL validity.
  • CAPTURE Files in External Storage: PLAN REPLAYER CAPTURE files can also be stored in external storage, with the token column continuing to record the file token for retrieval.
  • System Variable Updates: Descriptions for tidb_cloud_storage_uri and @@tidb_last_plan_replayer_token system variables have been updated to reflect these new storage behaviors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sql-plan-replayer.md
    • Added information about PLAN REPLAYER using tidb_cloud_storage_uri for external storage.
    • Updated PLAN REPLAYER DUMP output to include presigned URLs.
    • Clarified the download process for both presigned URLs and file tokens.
    • Updated note on file retention to include external storage.
    • Added information about PLAN REPLAYER CAPTURE using external storage.
  • system-variables.md
    • Updated tidb_cloud_storage_uri description to include PLAN REPLAYER as a feature that uses it.
    • Updated @@tidb_last_plan_replayer_token description to mention presigned URLs.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for PLAN REPLAYER to reflect its new object storage capabilities. The changes clarify how PLAN REPLAYER DUMP and PLAN REPLAYER CAPTURE handle file storage with tidb_cloud_storage_uri, including the introduction of presigned URLs. The related system variable documentation is also updated. The changes are clear and accurate. I have one minor suggestion to improve stylistic consistency.

@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. and removed missing-translation-status This PR does not have translation status info. labels Mar 12, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 12, 2026

@zhaoshangzi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt added the area/tidb-cloud This PR relates to the area of TiDB Cloud. label Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 24, 2026
zeminzhou and others added 2 commits April 1, 2026 14:21
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zeminzhou and others added 6 commits April 1, 2026 14:22
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Apr 1, 2026

/retest

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 1, 2026

@zeminzhou: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-verify

Use /test all to run all jobs.

Details

In response to this:

/test pull-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 2, 2026

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd self-requested a review April 2, 2026 03:35
@Oreoxmt Oreoxmt closed this Apr 2, 2026
@Oreoxmt Oreoxmt reopened this Apr 2, 2026
@Oreoxmt Oreoxmt added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 2, 2026
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 2, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-24 05:42:41.270037868 +0000 UTC m=+246957.306108128: ☑️ agreed by Oreoxmt.
  • 2026-04-02 05:38:28.913785372 +0000 UTC m=+416314.119145429: ☑️ agreed by hfxsd.

zeminzhou and others added 4 commits April 2, 2026 13:46
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt Oreoxmt added the for-cloud-release This PR is related to TiDB Cloud release. label Apr 7, 2026
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Apr 13, 2026

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2026
Oreoxmt and others added 3 commits April 14, 2026 11:31
Co-authored-by: Aolin <aolinz@outlook.com>
clarify PLAN REPLAYER external storage behavior by deployment type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants