Skip to content

tikv: improve the note for s3-multi-part-size (#21841) - #21842

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
ti-chi-bot:cherry-pick-21841-to-master
Jul 28, 2026
Merged

tikv: improve the note for s3-multi-part-size (#21841)#21842
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
ti-chi-bot:cherry-pick-21841-to-master

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jul 28, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #21841

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

In real-world scenarios, a small percentage of customers still exceed their S3 API quotas, making this configuration still valuable. Since there is no other workaround and the configuration will not be removed, this update replaces the word "deprecated" with "configure with caution." This aims to reduce the hesitation or mental burden for customers who genuinely need to use it to resolve their issues.

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档
    • 更新 backup.s3-multi-part-size 配置项说明,补充 S3 限流可能导致备份失败的相关信息。
    • 增加风险提示:自 TiDB v6.1.1 起请谨慎设置该参数;分块过大时,网络波动可能导致上传失败或超时。
    • 保留原有分块大小说明及默认值信息。

@ti-chi-bot ti-chi-bot added lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 27edfca2-8a77-4043-abce-b8049b28ac7b

📥 Commits

Reviewing files that changed from the base of the PR and between 2ba27b6 and 10c536e.

📒 Files selected for processing (1)
  • tikv-configuration-file.md

📝 Walkthrough

Walkthrough

更新 backup.s3-multi-part-size 配置项文档,替换原有废弃说明,并补充 TiDB v6.1.1 起的设置注意事项及网络抖动风险。

Changes

S3 配置文档

Layer / File(s) Summary
S3 分块大小说明更新
tikv-configuration-file.md
更新 backup.s3-multi-part-size 的版本说明,补充过大分块在网络抖动时可能导致上传失败或超时的提示。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • pingcap/docs-cn#21841:同样更新 tikv-configuration-file.mdbackup.s3-multi-part-size 的相关说明。

Suggested labels: translation/from-docs, needs-cherry-pick-master, approved

Suggested reviewers: qiancai, lilin90

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning 缺少必填的“What is changed, added or deleted?”内容,模板要求的变更说明未完整填写。 补充“ What is changed, added or deleted?”部分,明确说明改了什么、为什么改,并保持与模板字段对应。
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题与实际变更一致,准确概括了对 s3-multi-part-size 说明的更新。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai

qiancai commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 28, 2026
@qiancai qiancai removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Jul 28, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 14361cf into pingcap:master Jul 28, 2026
11 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-21841-to-master branch July 28, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants