fix: serve zero-size files with proper content#311
Open
driphtyio wants to merge 1 commit into
Open
Conversation
When stat.size === 0 (e.g. /proc virtual filesystem files), don't limit the read stream to byte 0 and don't set Content-Length: 0. Let the stream read until EOF and use chunked transfer encoding. Fixes expressjs/express#4944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
stat.size === 0(e.g./procvirtual filesystem files), thesend()method was settingopts.end = 0andContent-Length: 0, causing the read stream to stop at byte 0 and the response to be empty.This fix guards
opts.endandContent-Lengthwithlen > 0. When size is 0, the read stream continues until EOF and Node.js uses chunked transfer encoding, which correctly serves zero-size-but-readable files.Fixes expressjs/express#4944