make sure LazyTableReference isn't resolved until referenced table has been initialised#758
Draft
dantownsend wants to merge 21 commits intomasterfrom
Draft
make sure LazyTableReference isn't resolved until referenced table has been initialised#758dantownsend wants to merge 21 commits intomasterfrom
LazyTableReference isn't resolved until referenced table has been initialised#758dantownsend wants to merge 21 commits intomasterfrom
Conversation
…has been initialised
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 90.91% 91.03% +0.11%
==========================================
Files 109 109
Lines 8214 8257 +43
==========================================
+ Hits 7468 7517 +49
+ Misses 746 740 -6
|
…s well as table class name
Using importlib could mean we get partially initialised modules
Merged
Member
Author
|
I'll keep this open for now, but improvements were made in #1040, so I'm not sure if this PR is required any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #757