Reuse FileExcluder instances in IgnoredError::shouldIgnore()#6055
Closed
staabm wants to merge 1 commit into
Closed
Reuse FileExcluder instances in IgnoredError::shouldIgnore()#6055staabm wants to merge 1 commit into
IgnoredError::shouldIgnore()#6055staabm wants to merge 1 commit into
Conversation
A fresh FileExcluder was constructed for every (error, ignore entry with a path) pair - each construction normalizes the path, runs a preg_match and stats the filesystem via is_file/is_dir. With a large baseline this ran tens of thousands of times per run. Memoize the excluder per working directory + path.
Contributor
Author
|
I had a workload which is marginally slow on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh FileExcluder was constructed for every (error, ignore entry with a path) pair - each construction normalizes the path, runs a preg_match and stats the filesystem via is_file/is_dir. With a large baseline this ran tens of thousands of times per run. Memoize the excluder per working directory + path.
picked from https://github.com/phpstan/phpstan-src/commits/worktree-spx-perf-hunt/