-
Notifications
You must be signed in to change notification settings - Fork 590
Implement @pure-unless-parameter-passed #6018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zonuexe
wants to merge
24
commits into
phpstan:2.2.x
Choose a base branch
from
zonuexe:feature/pure-unless-parameter-passed
base: 2.2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8bf7637
Parse @pure-unless-parameter-passed PHPDoc tag
zonuexe 830a2f4
Thread @pure-unless-parameter-passed through the reflection layer
zonuexe 0600994
Wire @pure-unless-parameter-passed into the analyser
zonuexe e075de3
Mark by-ref out-parameter builtins as @pure-unless-parameter-passed
zonuexe 3cdee85
Add tests for @pure-unless-parameter-passed
zonuexe 9266d3c
Cover the pre-PHP 8 parameter names for the by-ref out-parameter buil…
zonuexe 3d0b0a9
Honor @pure-unless-parameter-passed on constructor calls, unpacked an…
zonuexe a336616
Parse @pure-unless-parameter-passed via phpdoc-parser 2.3.3
zonuexe 65a2a94
Report certain impurity when a @pure-unless-parameter-passed argument…
zonuexe 390ecc2
Recognize @phpstan-pure-unless-callable-is-impure as a known tag
zonuexe 0f992f5
Report @pure-unless-parameter-passed on a non-optional parameter
zonuexe ae33471
Expose @pure-unless-parameter-passed parameters as a function-level map
zonuexe ac502b8
Test @pure-unless-parameter-passed with a variadic parameter
zonuexe 2823c48
Mark preg_filter() as @pure-unless-parameter-passed
zonuexe 39e3978
Combine the callable and parameter-passed purity verdicts
zonuexe 3fe1ca5
Update bin/functionMetadata_original.php
zonuexe 07535c7
Match arguments collected by a flagged variadic parameter
zonuexe eb61ac2
Check the body of a @pure-unless-parameter-passed function
zonuexe 53c2e5b
Emit every purity condition when generating the function metadata
zonuexe 1cee42d
Cover every @pure-unless-parameter-passed builtin mapping
zonuexe a3bdef2
Settle conditional purity where a callable value is invoked
zonuexe 9f5cb16
Describe the function metadata entries with one optional-key shape
zonuexe 98b2691
Drop comments that restate the code
zonuexe 575a810
Merge the two conditional purity parameter mergers into one class
zonuexe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.