Don't error with checkMissingCallableSignature: true about degraded closures
#4823
Conversation
|
We could raise the threshold to degenerate later.. need to test this in the origin slow snippets though |
|
An idea - we could degrade it only for literal array in code, but we wouldn't need to degrade it for array shapes? Meaning ConstantArrayTypeBuilder in TypeNodeResolver would be created in a different mode. Also maybe the limit for degrading closures could be higher? |
I don't see how this is possible, because the worst case scenario is built up over one assign per line |
|
I had to discard the previous fix because it discarded all perf benefits we got previosuly with #4684 |
|
This pull request has been marked as ready for review. |
| * isSameAs: \Closure(Scope, Node\Arg, Node\Arg): Node\Expr, | ||
| * isScalar: \Closure(Scope, Node\Arg): Node\Expr, | ||
| * isString: \Closure(Scope, Node\Arg): Node\Expr, | ||
| * isTrue: \Closure(Scope, Node\Arg): Node\Expr, |
There was a problem hiding this comment.
Please also assert what's the type of the property here.
3 participants
closes phpstan/phpstan#14012