Avoid false error on is_subclass_of#4472
Open
VincentLanglet wants to merge 4 commits intophpstan:2.1.xfrom
Open
Avoid false error on is_subclass_of#4472VincentLanglet wants to merge 4 commits intophpstan:2.1.xfrom
VincentLanglet wants to merge 4 commits intophpstan:2.1.xfrom
Conversation
a26609c to
31a5ad8
Compare
5500473 to
8576d53
Compare
VincentLanglet
commented
Oct 24, 2025
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
commented
Oct 24, 2025
Contributor
Author
|
This issue was more complicated than expected... I'm not against your opinion/review @staabm :) |
staabm
reviewed
Oct 29, 2025
staabm
reviewed
Oct 30, 2025
5aab962 to
b37f439
Compare
Contributor
Author
|
I dunno what to do about the webmozart-assert failure because I don't report anymore Technically, because a And currently, phpstan/phpstan-webmozart-assert#194 is showing the issue |
b37f439 to
16c3b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13713
Solves phpstan/phpstan#6305 (comment)