ext/uri: Increases test coverage - #23342
Draft
NickSdot wants to merge 15 commits into
Draft
Conversation
This test was sourced from gh22046.phpt which first was renamed and moved, then reverted. This adjusts the naming. Part of the test is now in both. Reason: should not remove the test case here just because a bug test has it as well.
NickSdot
force-pushed
the
hardening/ext-uri-coverage
branch
from
September 4, 2026 09:48
769f75b to
4da15d7
Compare
NickSdot
force-pushed
the
hardening/ext-uri-coverage
branch
from
September 4, 2026 12:12
4da15d7 to
10422c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: WIP -- needs work after #23551 and #23286!
Depends on #23286:
This is fully Codex made. I threw a coverage report at it to close uncovered lines/branch gaps. It came up with a tonne of edge cases; this PR is the result of me massaging it a bit, and after filtering out nonsense that did not actually increase coverage as well as things that seemed too esoteric. So everything here increases coverage even though things might seem already tested -- that's because of using slightly different api paths.