GH-22617: avoid null byte truncation of persistent stream keys#22704
Open
devnexen wants to merge 2 commits into
Open
GH-22617: avoid null byte truncation of persistent stream keys#22704devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
Abstract unix domain socket addresses begin with a null byte, but the persistent stream list is keyed by a NUL-terminated string. The key was truncated at that null byte, so distinct abstract sockets collapsed onto the same persistent resource in p(f)sockopen() and stream_socket_client(). Escape null bytes (and backslashes, to stay unambiguous) when building the persistent hash key so the full address is preserved. Fix php#22617
ndossche
reviewed
Jul 12, 2026
| zend_string *php_stream_escape_persistent_key(const char *host, size_t hostlen) | ||
| { | ||
| size_t escaped_len = 0, i; | ||
| for (i = 0; i < hostlen; i++) { |
Member
There was a problem hiding this comment.
Unless the input length is bounded, this can allow a string length overflow on 32-bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract unix domain socket addresses begin with a null byte, but the persistent stream list is keyed by a NUL-terminated string. The key was truncated at that null byte, so distinct abstract sockets collapsed onto the same persistent resource in p(f)sockopen() and stream_socket_client().
Escape null bytes (and backslashes, to stay unambiguous) when building the persistent hash key so the full address is preserved.